Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/285146
Change subject: Remove unused imports and locals ...................................................................... Remove unused imports and locals And a bit of cleanup of the overall PHP code style. Change-Id: I72769524f289a1f4a3b22ab5028fbf79a0415cca --- M includes/Hooks.php M includes/LuaLibrary.php M includes/lua/Infobox.lua M tests/phpunit/includes/lua/InfoboxRenderTest.php M tests/phpunit/includes/lua/InfoboxTest.php 5 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Capiunto refs/changes/46/285146/1 diff --git a/includes/Hooks.php b/includes/Hooks.php index 746b603..0368878 100644 --- a/includes/Hooks.php +++ b/includes/Hooks.php @@ -1,10 +1,6 @@ <?php -namespace Capiunto; -use OutputPage; -use Skin; -use RecursiveIteratorIterator; -use RecursiveDirectoryIterator; +namespace Capiunto; /** * File defining the hook handlers for the Capiunto extension. @@ -14,6 +10,7 @@ * @author Marius Hoch < [email protected] > */ class Hooks { + /** * Hook to add PHPUnit test cases. * @see https://www.mediawiki.org/wiki/Manual:Hooks/UnitTestsList diff --git a/includes/LuaLibrary.php b/includes/LuaLibrary.php index 0447335..4e4dc66 100644 --- a/includes/LuaLibrary.php +++ b/includes/LuaLibrary.php @@ -34,4 +34,5 @@ public function addResourceLoaderModules() { $this->getParser()->getOutput()->addModuleStyles( 'capiunto.infobox.main' ); } + } diff --git a/includes/lua/Infobox.lua b/includes/lua/Infobox.lua index 5e34c6a..3731614 100644 --- a/includes/lua/Infobox.lua +++ b/includes/lua/Infobox.lua @@ -20,7 +20,6 @@ metatable.__index = methodtable metatable.__tostring = function( t ) - local ret = {} return tostring( t:getHtml() ) end diff --git a/tests/phpunit/includes/lua/InfoboxRenderTest.php b/tests/phpunit/includes/lua/InfoboxRenderTest.php index 1394393..5464149 100644 --- a/tests/phpunit/includes/lua/InfoboxRenderTest.php +++ b/tests/phpunit/includes/lua/InfoboxRenderTest.php @@ -1,6 +1,7 @@ <?php namespace Capiunto\Test; + use Scribunto_LuaEngineTestBase; /** @@ -10,8 +11,8 @@ * * @author Marius Hoch < [email protected] > */ - class InfoboxRenderModuleTest extends Scribunto_LuaEngineTestBase { + protected static $moduleName = 'InfoboxRenderModuleTests'; function getTestModules() { @@ -19,4 +20,5 @@ 'InfoboxRenderModuleTests' => __DIR__ . '/InfoboxRenderTests.lua', ); } + } diff --git a/tests/phpunit/includes/lua/InfoboxTest.php b/tests/phpunit/includes/lua/InfoboxTest.php index 4461872..3369f7e 100644 --- a/tests/phpunit/includes/lua/InfoboxTest.php +++ b/tests/phpunit/includes/lua/InfoboxTest.php @@ -1,6 +1,7 @@ <?php namespace Capiunto\Test; + use Scribunto_LuaEngineTestBase; /** @@ -10,8 +11,8 @@ * * @author Marius Hoch < [email protected] > */ - class InfoboxModuleTest extends Scribunto_LuaEngineTestBase { + protected static $moduleName = 'InfoboxModuleTests'; function getTestModules() { -- To view, visit https://gerrit.wikimedia.org/r/285146 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I72769524f289a1f4a3b22ab5028fbf79a0415cca Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Capiunto Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
