Alex Monk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/285297

Change subject: Use correct case to access 
ve.ui.MWCategoryItemWidget.prototype.sortKey property
......................................................................

Use correct case to access ve.ui.MWCategoryItemWidget.prototype.sortKey property

Otherwise we just record undefined as the original sort key and never
allow blank sort keys.

Bug: T92632
Change-Id: I7f37a8a33c54186ec6f0f74e374c591d5428b119
---
M modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/97/285297/1

diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js 
b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
index 0fc06b1..94c9d3f 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
@@ -145,7 +145,7 @@
  * @param {ve.ui.MWCategoryItemWidget} item Category item
  */
 ve.ui.MWCategoryPopupWidget.prototype.loadCategoryIntoPopup = function ( item 
) {
-       this.origSortkey = item.sortkey;
+       this.origSortkey = item.sortKey;
        if ( item.isHidden ) {
                this.$hiddenStatus.text( ve.msg( 
'visualeditor-dialog-meta-categories-hidden' ) );
        } else if ( item.isMissing ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/285297
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f37a8a33c54186ec6f0f74e374c591d5428b119
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to