Filippo Giunchedi has submitted this change and it was merged. Change subject: Fix Beta update.php error handling ......................................................................
Fix Beta update.php error handling From Hashar's suggestion at https://phabricator.wikimedia.org/T110407#2030487 Bug: T110407 Change-Id: I7d1e4484fcd7b9db6ca6ae571c7147e943e0d4ae --- M modules/beta/files/wmf-beta-update-databases.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Thcipriani: Looks good to me, but someone else must approve Filippo Giunchedi: Verified; Looks good to me, approved diff --git a/modules/beta/files/wmf-beta-update-databases.py b/modules/beta/files/wmf-beta-update-databases.py index 8795365..2ddf28f 100755 --- a/modules/beta/files/wmf-beta-update-databases.py +++ b/modules/beta/files/wmf-beta-update-databases.py @@ -29,6 +29,7 @@ """ for p, f, cmd in procs: if p.wait() > 0: + f.seek(0) raise Exception("command: ", cmd, "output: ", f.read()) f.seek(0) print f.read().strip() -- To view, visit https://gerrit.wikimedia.org/r/282441 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d1e4484fcd7b9db6ca6ae571c7147e943e0d4ae Gerrit-PatchSet: 2 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Mattflaschen <[email protected]> Gerrit-Reviewer: Filippo Giunchedi <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: Thcipriani <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
