jenkins-bot has submitted this change and it was merged.
Change subject: Dialog: When reusing a reference, avoid popping up the group
menu
......................................................................
Dialog: When reusing a reference, avoid popping up the group menu
The group picker menu will open momentarily when the input is changed, unless
it's disabled when the change happens. This was mostly visible when selecting
a reference from the "use an existing reference dialog", as a flash of the
menu in the top-left of the screen.
Bug: T125862
Change-Id: Ib6d3715f7d123545ba688bfbe850fe3c26ccb6e1
---
M modules/ve-cite/ve.ui.MWReferenceDialog.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-cite/ve.ui.MWReferenceDialog.js
b/modules/ve-cite/ve.ui.MWReferenceDialog.js
index 3bb8000..8e65f20 100644
--- a/modules/ve-cite/ve.ui.MWReferenceDialog.js
+++ b/modules/ve-cite/ve.ui.MWReferenceDialog.js
@@ -267,7 +267,10 @@
// Initialization
this.originalGroup = this.referenceModel.getGroup();
+ // Set the group input while it's disabled, so this doesn't pop up the
group-picker menu
+ this.referenceGroupInput.setDisabled( true );
this.referenceGroupInput.input.setValue( this.originalGroup );
+ this.referenceGroupInput.setDisabled( false );
this.contentFieldset.$element.append( this.referenceTarget.$element );
this.referenceTarget.initialize();
--
To view, visit https://gerrit.wikimedia.org/r/285421
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6d3715f7d123545ba688bfbe850fe3c26ccb6e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Cite
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
