Glaisher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/285422
Change subject: Allow users with 'abusefilter-view-private' to view
history/diff of private filters
......................................................................
Allow users with 'abusefilter-view-private' to view history/diff of private
filters
These pages are read only pages so it's better to let users with
'abusefilter-view-private' to view history and diff of private filters
while 'abusefilter-modify' is a read+write right.
Bug: T126129
Change-Id: I9e15326c8d681000ab13ef8a50fa0eed4c24dbe6
---
M Views/AbuseFilterViewDiff.php
M Views/AbuseFilterViewHistory.php
2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/AbuseFilter
refs/changes/22/285422/1
diff --git a/Views/AbuseFilterViewDiff.php b/Views/AbuseFilterViewDiff.php
index 328d5a0..1c9e61a 100644
--- a/Views/AbuseFilterViewDiff.php
+++ b/Views/AbuseFilterViewDiff.php
@@ -99,9 +99,9 @@
$newSpec = $this->mParams[4];
$this->mFilter = $this->mParams[1];
- if ( AbuseFilter::filterHidden( $this->mFilter ) &&
- !$this->getUser()->isAllowed(
'abusefilter-modify' ) &&
- !$this->getUser()->isAllowed(
'abusefilter-view-private' ) ) {
+ if ( AbuseFilter::filterHidden( $this->mFilter )
+ && !$this->getUser()->isAllowed(
'abusefilter-view-private' )
+ ) {
$this->getOutput()->addWikiMsg(
'abusefilter-history-error-hidden' );
return false;
}
diff --git a/Views/AbuseFilterViewHistory.php b/Views/AbuseFilterViewHistory.php
index bedbafc..e81577f 100644
--- a/Views/AbuseFilterViewHistory.php
+++ b/Views/AbuseFilterViewHistory.php
@@ -17,9 +17,9 @@
}
# Check perms
- if ( $filter &&
- !$this->getUser()->isAllowed(
'abusefilter-modify' ) &&
- AbuseFilter::filterHidden( $filter ) ) {
+ if ( $filter && AbuseFilter::filterHidden( $filter )
+ && !$this->getUser()->isAllowed(
'abusefilter-view-private' )
+ ) {
$out->addWikiMsg( 'abusefilter-history-error-hidden' );
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/285422
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9e15326c8d681000ab13ef8a50fa0eed4c24dbe6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Glaisher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
