jenkins-bot has submitted this change and it was merged. Change subject: Follow-up b10bd7003: allow object instead of array for b/c with wikis running old code ......................................................................
Follow-up b10bd7003: allow object instead of array for b/c with wikis running old code Change-Id: I1566b73e0d8daea6c2e701f60cbcb9dd42129ec9 (cherry picked from commit 1608a5e6fc4e8fd6320153bb3ec8d5574154fd2c) --- M modules/viewmodel/mw.echo.dm.NotificationsModel.js 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/viewmodel/mw.echo.dm.NotificationsModel.js b/modules/viewmodel/mw.echo.dm.NotificationsModel.js index 4c77b37..ae07c74 100644 --- a/modules/viewmodel/mw.echo.dm.NotificationsModel.js +++ b/modules/viewmodel/mw.echo.dm.NotificationsModel.js @@ -481,7 +481,8 @@ data = data || {}; - for ( i = 0; i < data.list.length; i++ ) { + // Backwards compatibility: data.list used to be an object + for ( i in data.list ) { notifData = data.list[ i ]; content = notifData[ '*' ] || {}; -- To view, visit https://gerrit.wikimedia.org/r/285550 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1566b73e0d8daea6c2e701f60cbcb9dd42129ec9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Echo Gerrit-Branch: wmf/1.27.0-wmf.22 Gerrit-Owner: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits