IAlex has submitted this change and it was merged. Change subject: testDecodeTagAttributes now use a data provider ......................................................................
testDecodeTagAttributes now use a data provider We had a huge pile of assertEquals in a single test function, this patch convert the mess in a nicer dataprovider. The parameters passed to assertEquals() were mixed up, the expected values should be passed as the first argument, I thus exchange the first two parameters in each case. Change-Id: Ib74804a7aa84a1e59fffb8c85abbf0b95995d897 --- M tests/phpunit/includes/SanitizerTest.php 1 file changed, 49 insertions(+), 40 deletions(-) Approvals: IAlex: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34699 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib74804a7aa84a1e59fffb8c85abbf0b95995d897 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Hashar <[email protected]> Gerrit-Reviewer: IAlex <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
