Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/285661
Change subject: Reinstate Firefox img hack for versions >= 38
......................................................................
Reinstate Firefox img hack for versions >= 38
Partially reverts I0ee0daaab6b27198f3239a64648d82c5c19444af
Bug: T133610
Change-Id: I4e5a000652a83059c254d56763fa7367b6554928
(cherry picked from commit 0b8ac09e2bad06f29e7bd465eb85ab06d5b6df05)
---
M src/ce/ve.ce.BranchNode.js
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/61/285661/1
diff --git a/src/ce/ve.ce.BranchNode.js b/src/ce/ve.ce.BranchNode.js
index 10e3107..bbecc6e 100644
--- a/src/ce/ve.ce.BranchNode.js
+++ b/src/ce/ve.ce.BranchNode.js
@@ -68,10 +68,11 @@
.addClass( 've-ce-branchNode-slug
ve-ce-branchNode-inlineSlug' )
.append( $img );
- // Support: Firefox<=37
- // Firefox misbehaves if we don't set an src:
https://bugzilla.mozilla.org/show_bug.cgi?id=989012
+ // Support: Firefox
+ // Firefox <=37 misbehaves if we don't set an src:
https://bugzilla.mozilla.org/show_bug.cgi?id=989012
+ // Firefox misbehaves if we don't set an src and there is no sizing at
node creation time: https://bugzilla.mozilla.org/show_bug.cgi?id=1267906
// Setting an src in Chrome is slow, so only set it in affected
versions of Firefox
- if ( profile.layout === 'gecko' && profile.versionNumber < 38 ) {
+ if ( profile.layout === 'gecko' ) {
$img.prop( 'src', ve.ce.minImgDataUri );
}
return $span.get( 0 );
--
To view, visit https://gerrit.wikimedia.org/r/285661
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e5a000652a83059c254d56763fa7367b6554928
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: wmf/1.27.0-wmf.22
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Divec <da...@troi.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
