[MediaWiki-commits] [Gerrit] Add test for integer value generated by geo-serializer - change (wikidata...rdf)

[Smalyshev (Code Review)]

Smalyshev has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/286251

Change subject: Add test for integer value generated by geo-serializer
......................................................................

Add test for integer value generated by geo-serializer

Change-Id: I29d8d3f3f6009e75d0ffb6d31fc1acdfbbd1de25
---
M 
blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/AbstractRandomizedBlazegraphStorageTestCase.java
M 
blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/WikibaseGeoUnitTest.java
2 files changed, 17 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/rdf 
refs/changes/51/286251/1

diff --git 
a/blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/AbstractRandomizedBlazegraphStorageTestCase.java
 
b/blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/AbstractRandomizedBlazegraphStorageTestCase.java
index 3e31ba7..230d7f4 100644
--- 
a/blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/AbstractRandomizedBlazegraphStorageTestCase.java
+++ 
b/blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/AbstractRandomizedBlazegraphStorageTestCase.java
@@ -83,6 +83,7 @@
         
properties.setProperty("com.bigdata.rdf.store.AbstractTripleStore.extensionFactoryClass",
                 WikibaseExtensionFactory.class.getName());
         
properties.setProperty("com.bigdata.rdf.store.AbstractTripleStore.geoSpatial", 
"true");
+        
properties.setProperty("com.bigdata.rdf.store.AbstractTripleStore.geoSpatialIncludeBuiltinDatatypes",
  "false");
         
properties.setProperty("com.bigdata.rdf.store.AbstractTripleStore.geoSpatialDefaultDatatype",
 "http://www.opengis.net/ont/geosparql#wktLiteral";);
         
properties.setProperty("com.bigdata.rdf.store.AbstractTripleStore.geoSpatialDatatypeConfig.0",
                 "{\"config\": "
@@ -91,7 +92,7 @@
                         + "\"fields\": [ "
                         + "{ \"valueType\": \"DOUBLE\", \"multiplier\": 
\"1000000000\", \"serviceMapping\": \"LONGITUDE\" }, "
                         + "{ \"valueType\": \"DOUBLE\", \"multiplier\": 
\"1000000000\", \"serviceMapping\": \"LATITUDE\" }, "
-                        + "{ \"valueType\": \"LONG\", \"serviceMapping\": 
\"COORD_SYSTEM\" } "
+                        + "{ \"valueType\": \"LONG\", 
\"multiplier\":\"1\",\"minValue\":\"0\", \"serviceMapping\": \"COORD_SYSTEM\" } 
"
                         + "]}}");
         store = new TempTripleStore(temporaryStore(), properties, null);
         return store;
diff --git 
a/blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/WikibaseGeoUnitTest.java
 
b/blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/WikibaseGeoUnitTest.java
index 632039d..13cd54c 100644
--- 
a/blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/WikibaseGeoUnitTest.java
+++ 
b/blazegraph/src/test/java/org/wikidata/query/rdf/blazegraph/WikibaseGeoUnitTest.java
@@ -2,17 +2,21 @@
 
 import static org.hamcrest.Matchers.instanceOf;
 
+import java.math.BigInteger;
+
 import org.junit.Test;
+import org.openrdf.model.Literal;
 import org.openrdf.model.impl.LiteralImpl;
 import org.openrdf.model.impl.URIImpl;
 import org.wikidata.query.rdf.common.uri.GeoSparql;
 import org.wikidata.query.rdf.common.uri.Ontology;
 
 import com.bigdata.rdf.internal.impl.literal.LiteralExtensionIV;
+import com.bigdata.rdf.internal.impl.literal.XSDIntegerIV;
+import com.bigdata.rdf.lexicon.LexiconRelation;
 import com.bigdata.rdf.model.BigdataStatement;
 
 public class WikibaseGeoUnitTest extends AbstractRandomizedBlazegraphTestBase {
-
     @Test
     public void geoExtension() {
         BigdataStatement statement = roundTrip(Ontology.Geo.GLOBE, 
Ontology.Geo.LATITUDE,
@@ -31,4 +35,14 @@
         assertEquals(statement.getObject().toString(),
                 "\"" + point + "\"^^<" + GeoSparql.WKT_LITERAL + ">");
     }
+
+    @Test
+    @SuppressWarnings("rawtypes")
+    public void testInteger() {
+        LexiconRelation rel = store().getLexiconRelation();
+        Literal l = new LiteralImpl("Point(40.4426 -80.0068)", new 
URIImpl(GeoSparql.WKT_LITERAL));
+        LiteralExtensionIV iv = (LiteralExtensionIV)rel.getInlineIV(l);
+        assertEquals(GeoSparql.WKT_LITERAL, 
iv.getExtensionIV().getValue().toString());
+        assertEquals(new XSDIntegerIV(new 
BigInteger("1008819921758573694187894119050371595694851885687493623808")), 
iv.getDelegate());
+    }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/286251
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I29d8d3f3f6009e75d0ffb6d31fc1acdfbbd1de25
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Smalyshev <smalys...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits