Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/286280
Change subject: Give redirects a sort index in title widget
......................................................................
Give redirects a sort index in title widget
Otherwise the sort compare function returns NaN
and the order is completely broken.
Bug: T134020
Change-Id: Ie3bbc153e6941d35cfab971690c8934123185d48
---
M resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/80/286280/1
diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
b/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
index 3d97711..fdd4a8a 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.TitleWidget.js
@@ -182,7 +182,7 @@
disambiguation: OO.getProp( suggestionPage,
'pageprops', 'disambiguation' ) !== undefined,
imageUrl: OO.getProp( suggestionPage,
'thumbnail', 'source' ),
description: OO.getProp( suggestionPage,
'terms', 'description' ),
- // sort index
+ // Sort index
index: suggestionPage.index
};
@@ -198,7 +198,9 @@
missing: false,
redirect: true,
disambiguation: false,
- description: mw.msg(
'mw-widgets-titleinput-description-redirect', suggestionPage.title )
+ description: mw.msg(
'mw-widgets-titleinput-description-redirect', suggestionPage.title ),
+ // Sort index, just below its target
+ index: suggestionPage.index + 0.5
};
titles.push( redirects[ i ] );
}
--
To view, visit https://gerrit.wikimedia.org/r/286280
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3bbc153e6941d35cfab971690c8934123185d48
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
