Gergő Tisza has uploaded a new change for review.
https://gerrit.wikimedia.org/r/286499
Change subject: Fix HTMLForm noData logic in trySubmit
......................................................................
Fix HTMLForm noData logic in trySubmit
This was missed in If4e0dfb and causes missing array key warnings
for fields using skipLoadData.
Change-Id: Ib52ee2bc9af278f03b48730acc1edb30f5ff1f88
---
M includes/htmlform/HTMLForm.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/99/286499/1
diff --git a/includes/htmlform/HTMLForm.php b/includes/htmlform/HTMLForm.php
index d671029..9cad7bf 100644
--- a/includes/htmlform/HTMLForm.php
+++ b/includes/htmlform/HTMLForm.php
@@ -569,7 +569,7 @@
# Check for cancelled submission
foreach ( $this->mFlatFields as $fieldname => $field ) {
- if ( !empty( $field->mParams['nodata'] ) ) {
+ if ( !array_key_exists( $fieldname, $this->mFieldData )
) {
continue;
}
if ( $field->cancelSubmit(
$this->mFieldData[$fieldname], $this->mFieldData ) ) {
@@ -580,7 +580,7 @@
# Check for validation
foreach ( $this->mFlatFields as $fieldname => $field ) {
- if ( !empty( $field->mParams['nodata'] ) ) {
+ if ( !array_key_exists( $fieldname, $this->mFieldData )
) {
continue;
}
if ( $field->isHidden( $this->mFieldData ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/286499
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib52ee2bc9af278f03b48730acc1edb30f5ff1f88
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
