Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/286503

Change subject: mw-fetch-composer-dev.sh fails when node is absent
......................................................................

mw-fetch-composer-dev.sh fails when node is absent

Bash -e ignores failures in pipe:

false | true

set -o pipefail to have bash abort as soon as there is an error, for
example when 'node' is not found.

Change-Id: I048d77a1510e0f615a9a9ba962a6981e012cbc15
---
M bin/mw-fetch-composer-dev.sh
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/jenkins 
refs/changes/03/286503/1

diff --git a/bin/mw-fetch-composer-dev.sh b/bin/mw-fetch-composer-dev.sh
index 06a2e20..e8eb8d2 100755
--- a/bin/mw-fetch-composer-dev.sh
+++ b/bin/mw-fetch-composer-dev.sh
@@ -7,6 +7,7 @@
 # Load require-dev packages on top of mediawiki/vendor (T112895)
 # Once jq 1.4 is available, the following may be used instead:
 # > jq -r '.["require-dev"]|to_entries|map([.key,.value])[]|join("=")' 
../composer.json
+set -o pipefail
 node $(dirname $0)/../tools/composer-dev-args.js 
"$MW_INSTALL_PATH/composer.json" | xargs composer require --dev --ansi 
--no-progress --prefer-dist -v
 
 # FIXME: integration/composer is outdated and breaks autoloader

-- 
To view, visit https://gerrit.wikimedia.org/r/286503
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I048d77a1510e0f615a9a9ba962a6981e012cbc15
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to