WMDE-leszek has submitted this change and it was merged.
Change subject: Added jscs checks for tests
......................................................................
Added jscs checks for tests
Change-Id: Ice2d37f40105d082fd10ebc7a83bd1ef02919eb4
---
M .jshintrc
M Gruntfile.js
M tests/RevisionSlider.Revision.test.js
M tests/RevisionSlider.test.js
4 files changed, 8 insertions(+), 7 deletions(-)
Approvals:
WMDE-leszek: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/.jshintrc b/.jshintrc
index 69882aa..eb08746 100755
--- a/.jshintrc
+++ b/.jshintrc
@@ -17,6 +17,7 @@
"mw": false,
"$": false,
"mediaWiki": false,
- "jQuery": false
+ "jQuery": false,
+ "QUnit": false
}
}
diff --git a/Gruntfile.js b/Gruntfile.js
index 56ff218..cac1384 100755
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -12,6 +12,7 @@
},
all: [
'*.js',
+ 'tests/*.js',
'modules/**/*.js'
]
},
diff --git a/tests/RevisionSlider.Revision.test.js
b/tests/RevisionSlider.Revision.test.js
index df2063e..b807492 100644
--- a/tests/RevisionSlider.Revision.test.js
+++ b/tests/RevisionSlider.Revision.test.js
@@ -1,4 +1,4 @@
-(function ( mw, $ ) {
+( function ( mw ) {
QUnit.module( 'ext.RevisionSlider.Revision' );
QUnit.test( 'create Revision', function ( assert ) {
@@ -20,8 +20,7 @@
QUnit.test( 'get Revision with section', function ( assert ) {
var data = {
- comment: '/* section */ comment',
- parsedcomment: '<b>hello</b>'
+ comment: '/* section */ comment'
},
rev = new mw.libs.revisionSlider.Revision( data );
@@ -36,5 +35,5 @@
assert.equal( rev.getSection(), '' );
} );
+} )( mediaWiki );
-})( mediaWiki, jQuery );
diff --git a/tests/RevisionSlider.test.js b/tests/RevisionSlider.test.js
index 336d3dd..6e28b21 100755
--- a/tests/RevisionSlider.test.js
+++ b/tests/RevisionSlider.test.js
@@ -1,4 +1,4 @@
-( function ( mw, $ ) {
+( function () {
QUnit.module( 'ext.RevisionSlider' );
/**
@@ -9,4 +9,4 @@
*
https://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing#Write_a_unit_test
*/
-} )( mediaWiki, jQuery );
+} )();
--
To view, visit https://gerrit.wikimedia.org/r/286618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice2d37f40105d082fd10ebc7a83bd1ef02919eb4
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <christoph.fisc...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Gabriel Birke <gabriel.bi...@wikimedia.de>
Gerrit-Reviewer: Jakob <jakob.warkot...@wikimedia.de>
Gerrit-Reviewer: Kai Nissen (WMDE) <kai.nis...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WMDE-Fisch <christoph.fisc...@wikimedia.de>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
