Awight has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/286702

Change subject: Defaults and comments
......................................................................

Defaults and comments

Change-Id: I0af169a3efa2cf7ffc7efeea8f4de2e9ff1a61fb
---
M DonationInterface.php
M paypal_gateway/legacy/paypal_legacy.adapter.php
2 files changed, 4 insertions(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface 
refs/changes/02/286702/1

diff --git a/DonationInterface.php b/DonationInterface.php
index 7e78a58..651e6f1 100644
--- a/DonationInterface.php
+++ b/DonationInterface.php
@@ -163,6 +163,7 @@
  * Global form dir
  */
 $wgDonationInterfaceHtmlFormDir = __DIR__ . '/gateway_forms/rapidhtml/html';
+# FIXME: Consider defaulting to true.
 $wgDonationInterfaceTest = false;
 
 /**
@@ -277,7 +278,8 @@
  * Where to send donors who click a 'cancel' button on a payment processor's 
web site.
  * Currently only used with PayPal.
  */
-$wgDonationInterfaceCancelPage = ''; 
//https://wikimediafoundation.org/wiki/Ways_to_Give
+//$wgDonationInterfaceCancelPage = 
'https://wikimediafoundation.org/wiki/Ways_to_Give';
+$wgDonationInterfaceCancelPage = 'Donate-error';
 
 /**
  * Retry Loop Count - If there's a place where the API can choose to loop on 
some retry behavior, do it this number of times.
diff --git a/paypal_gateway/legacy/paypal_legacy.adapter.php 
b/paypal_gateway/legacy/paypal_legacy.adapter.php
index 4f38a31..63308c4 100644
--- a/paypal_gateway/legacy/paypal_legacy.adapter.php
+++ b/paypal_gateway/legacy/paypal_legacy.adapter.php
@@ -187,6 +187,7 @@
                        case 'Donate':
                        case 'DonateXclick':
                        case 'DonateRecurring':
+                               // FIXME: Push into a standard 
namevalue+redirect handler.
                                $this->transactions[ $transaction ][ 'url' ] =
                                        $this->getGlobal( 'URL' ) . '?' . 
http_build_query( $this->buildRequestParams() );
                                $result = parent::do_transaction( $transaction 
);

-- 
To view, visit https://gerrit.wikimedia.org/r/286702
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0af169a3efa2cf7ffc7efeea8f4de2e9ff1a61fb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to