Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/286766
Change subject: PayPal EC gets donor details back using API call
......................................................................
PayPal EC gets donor details back using API call
Bug: T131811
Change-Id: I3b91d55dc137e59a8db85b4e1be8e1ceafbc5692
---
M paypal_gateway/express_checkout/config/var_map.yaml
M paypal_gateway/express_checkout/paypal_express.adapter.php
2 files changed, 11 insertions(+), 7 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/66/286766/1
diff --git a/paypal_gateway/express_checkout/config/var_map.yaml
b/paypal_gateway/express_checkout/config/var_map.yaml
index 25f03e8..dd6e75c 100644
--- a/paypal_gateway/express_checkout/config/var_map.yaml
+++ b/paypal_gateway/express_checkout/config/var_map.yaml
@@ -5,19 +5,19 @@
#returnUrl: const
#VERSION
-PAYMENTREQUEST_0_AMT: amount
LOCALECODE: language
EMAIL: email
+TOKEN: ec_token
+PAYERID: payer_id
+RETURNURL: returnto
+PAYMENTREQUEST_0_AMT: amount
PAYMENTREQUEST_0_CURRENCYCODE: currency_code
-PAYMENTREQUEST_0_ITEMAMT: amount
# TODO: deprecated
PAYMENTREQUEST_0_CUSTOM: contribution_tracking_id
# FIXME: Update the audit and IPN listener to read from this field.
PAYMENTREQUEST_0_INVNUM: contribution_tracking_id
-TOKEN: ec_token
-PAYERID: payer_id
-RETURNURL: returnto
-PAYMENTINFO_0_TRANSACTIONID: gateway_txn_id
+PAYMENTREQUEST_0_ITEMAMT: amount
# Example: 2016%2d05%2d03T21%3a25%3a22Z&
PAYMENTINFO_0_ORDERTIME: date
PAYMENTINFO_0_PAYMENTSTATUS: gateway_status
+PAYMENTINFO_0_TRANSACTIONID: gateway_txn_id
diff --git a/paypal_gateway/express_checkout/paypal_express.adapter.php
b/paypal_gateway/express_checkout/paypal_express.adapter.php
index 7616e87..2421969 100644
--- a/paypal_gateway/express_checkout/paypal_express.adapter.php
+++ b/paypal_gateway/express_checkout/paypal_express.adapter.php
@@ -256,7 +256,11 @@
$this->finalizeInternalStatus(
FinalStatus::FAILED );
break;
}
- // TODO: merge response into my data
+
+ // Merge response into our transaction data.
+ // XXX--wait, there's no default function to unstage
using var_map?
+ $this->addResponseData( $this->unstageKeys( $response )
);
+
$this->runAntifraudHooks();
if ( $this->getValidationAction() !== 'process' ) {
$this->finalizeInternalStatus(
FinalStatus::FAILED );
--
To view, visit https://gerrit.wikimedia.org/r/286766
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b91d55dc137e59a8db85b4e1be8e1ceafbc5692
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
