GWicke has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/287148

Change subject: Set conservative retry limits & delays
......................................................................

Set conservative retry limits & delays

Changeprop was previously using the default retry limits & delays of:
- 500ms delay
- up to 5 retries.

This patch changes these values to something more reasonable:
- 60s delay, and
- up to 2 retries.

Bug: T134456
Change-Id: Ifaf44d1562681758e8d44ec7cc9fa1faf99374e5
---
M modules/changeprop/templates/config.yaml.erb
1 file changed, 12 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/48/287148/1

diff --git a/modules/changeprop/templates/config.yaml.erb 
b/modules/changeprop/templates/config.yaml.erb
index cd7d456..6130ae4 100644
--- a/modules/changeprop/templates/config.yaml.erb
+++ b/modules/changeprop/templates/config.yaml.erb
@@ -26,6 +26,12 @@
             templates:
               summary_rerender:
                 topic: resource_change
+                retry_limit: 2
+                # 1 minute
+                retry_delay: 60000
+                retry_on:
+                  status:
+                    - '5xx'
                 match:
                   meta:
                     uri: 
'/^https?:\/\/[^\/]+\/api\/rest_v1\/page\/html\/([^\/]+)$/'
@@ -43,6 +49,12 @@
 
               definition_rerender:
                 topic: resource_change
+                retry_limit: 2
+                # 1 minute
+                retry_delay: 60000
+                retry_on:
+                  status:
+                    - '5xx'
                 match:
                   meta:
                     # These URIs are coming from RESTBase, so we know that 
article titles will be normalized

-- 
To view, visit https://gerrit.wikimedia.org/r/287148
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifaf44d1562681758e8d44ec7cc9fa1faf99374e5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: GWicke <gwi...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to