jenkins-bot has submitted this change and it was merged.
Change subject: Remove upgradeRow() call from ?action=purge
......................................................................
Remove upgradeRow() call from ?action=purge
This is overkill and can cause excess lock contention
on larger files. Purges are typically used to fix
thumbnails or CDN, not metadata. Scripts can always
be run to fix any real breakage.
Bug: T132921
Change-Id: Ieecf1c015735b7219ca51c87951b59c453cf588f
---
M includes/page/WikiFilePage.php
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Brion VIBBER: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/page/WikiFilePage.php b/includes/page/WikiFilePage.php
index a6b9915..0dc28bd 100644
--- a/includes/page/WikiFilePage.php
+++ b/includes/page/WikiFilePage.php
@@ -26,12 +26,13 @@
* @ingroup Media
*/
class WikiFilePage extends WikiPage {
- /**
- * @var File
- */
+ /** @var File */
protected $mFile = false;
+ /** @var LocalRepo */
protected $mRepo = null;
+ /** @var bool */
protected $mFileLoaded = false;
+ /** @var array */
protected $mDupes = null;
public function __construct( $title ) {
@@ -170,7 +171,6 @@
if ( $this->mFile->exists() ) {
wfDebug( 'ImagePage::doPurge purging ' .
$this->mFile->getName() . "\n" );
DeferredUpdates::addUpdate( new HTMLCacheUpdate(
$this->mTitle, 'imagelinks' ) );
- $this->mFile->upgradeRow();
$this->mFile->purgeCache( [ 'forThumbRefresh' => true ]
);
} else {
wfDebug( 'ImagePage::doPurge no image for '
--
To view, visit https://gerrit.wikimedia.org/r/286925
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieecf1c015735b7219ca51c87951b59c453cf588f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
