Daniel Werner has uploaded a new change for review. Change subject: (bug 43006) Simpler implementation of disable for SnakTypeSelector ......................................................................
(bug 43006) Simpler implementation of disable for SnakTypeSelector This basically reverts the enable/disable implementation of I14e89ecc and introduces an alternative approach. Also fixes the problem that the SnakTypeSelector would not work anymore after I14e89ecc got merged too early. The new approach will not change event listeners but instead, the widget simply won't display the menu anymore in case the widget's current state is set to disabled. Also improved events bound to window/document for listening whether the menu should be hidden after a click. This will now support multiple instances of the widget. There will still be one listener per opened menu of an instance. The difference is, that only the listener of the instances whose menu has been closed will be removed (before, listeners of all instances were removed as any menu did close). Change-Id: I4952fd505814877568a47a4807c56caa8b82b16f --- M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.SnakTypeSelector.js 1 file changed, 42 insertions(+), 48 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/33/44833/1 -- To view, visit https://gerrit.wikimedia.org/r/44833 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4952fd505814877568a47a4807c56caa8b82b16f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
