Aaron Schulz has uploaded a new change for review. Change subject: (bug 44024) ObjectCache changes break XCache 3.x support ......................................................................
(bug 44024) ObjectCache changes break XCache 3.x support Changes in the 1.20.x branch altered the add method to check for the return value of get against false. Xcache 3.x returns NULL for unset values and so this check was erroneously determining that all values are set when they were not. This was causing basic ObjectCache usage to fail. Change-Id: I0975e5c6a60c2813dc2d02aca84245807b8fb828 (cherry picked from commit 0072e0efeb8591a7761b3d573f8b71ef97fb96ec) --- M includes/objectcache/XCacheBagOStuff.php 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/46/44846/1 -- To view, visit https://gerrit.wikimedia.org/r/44846 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0975e5c6a60c2813dc2d02aca84245807b8fb828 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: REL1_20 Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Brent Garber <overlo...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
