BBlack has submitted this change and it was merged.
Change subject: tlsproxy: switch to (non-persistent) HTTP/1.1
......................................................................
tlsproxy: switch to (non-persistent) HTTP/1.1
This should make very little functional difference at present, but
it's more-correct. We'll still have default 'Connection: close'
on every proxied request with this change, but nginx will use
HTTP/1.1 instead of HTTP/1.0. In nginx code terms, this makes
very little difference other than the 'HTTP/1.1' on the request
line, so long as proxy_request_buffering is still at its
present/default value of 'on'...
Bug: T134870
Change-Id: I215d3018ba80757db305ed39615d9c7a41d80526
---
M modules/tlsproxy/templates/localssl.erb
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
BBlack: Verified; Looks good to me, approved
diff --git a/modules/tlsproxy/templates/localssl.erb
b/modules/tlsproxy/templates/localssl.erb
index 2c14ca7..60c8b12 100644
--- a/modules/tlsproxy/templates/localssl.erb
+++ b/modules/tlsproxy/templates/localssl.erb
@@ -30,9 +30,11 @@
location / {
proxy_pass http://local_fe_<%= @basename %>;
-<% if @keepalives_per_worker.to_i > 0 -%>
proxy_http_version 1.1;
+<% if @keepalives_per_worker.to_i > 0 -%>
proxy_set_header Connection "";
+<% else -%>
+ proxy_set_header Connection close; # note: this is default
<% end -%>
# this should be in sync with Varnish's first_byte_timeout
--
To view, visit https://gerrit.wikimedia.org/r/287995
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I215d3018ba80757db305ed39615d9c7a41d80526
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BBlack <[email protected]>
Gerrit-Reviewer: BBlack <[email protected]>
Gerrit-Reviewer: Ema <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
