Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288040
Change subject: Hygiene: suppress unwanted lint
......................................................................
Hygiene: suppress unwanted lint
Change-Id: Ida51a88f1bdaa9f1e0369b69d76f0d6d14f44975
---
M app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/40/288040/1
diff --git a/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
b/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
index 8d800e7..fe5156a 100644
--- a/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
+++ b/app/src/main/java/org/wikipedia/nearby/NearbyFragment.java
@@ -1,6 +1,7 @@
package org.wikipedia.nearby;
import android.Manifest;
+import android.annotation.SuppressLint;
import android.content.Context;
import android.content.SharedPreferences;
import android.content.pm.PackageManager;
@@ -401,6 +402,7 @@
.icon(markerIconPassive);
}
+ @SuppressLint("CommitPrefEdits")
private void disableTelemetry() {
// setTelemetryEnabled() does not write to shared prefs unless a
change is detected.
// However, it is initialized to false and then defaulted to true when
retrieving from
@@ -408,6 +410,9 @@
// to Mapbox's private shared prefs directly.
setTelemetryEnabled(true) would start the
// service at least briefly so the latter approach is used.
+ // Lint recommends editor.apply() instead of commit() because it
blocks but we really want
+ // to be certain that telemetry isn't enabled.
+
SharedPreferences prefs =
getContext().getSharedPreferences(MapboxConstants.MAPBOX_SHARED_PREFERENCES_FILE,
Context.MODE_PRIVATE);
SharedPreferences.Editor editor = prefs.edit();
--
To view, visit https://gerrit.wikimedia.org/r/288040
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida51a88f1bdaa9f1e0369b69d76f0d6d14f44975
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
