Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/288050

Change subject: Don't allow pointer clicks while timeline is sliding
......................................................................

Don't allow pointer clicks while timeline is sliding

Bug: T133279
Change-Id: I46add92298ac41b06437eef59f33a0ee64c4ccf0
---
M modules/ext.RevisionSlider.SliderView.js
1 file changed, 15 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider 
refs/changes/50/288050/1

diff --git a/modules/ext.RevisionSlider.SliderView.js 
b/modules/ext.RevisionSlider.SliderView.js
index 9f2ddb7..4a4d575 100644
--- a/modules/ext.RevisionSlider.SliderView.js
+++ b/modules/ext.RevisionSlider.SliderView.js
@@ -120,11 +120,22 @@
                },
 
                slide: function ( direction, duration ) {
-                       this.slider.slide( direction );
+                       var self = this;
 
-                       this.$element.find( '.revisions-container' ).animate( {
-                               scrollLeft: 
this.slider.getFirstVisibleRevisionIndex() * this.revisionWidth
-                       }, duration );
+                       this.slider.slide( direction );
+                       self.leftPointer.getView().getElement().draggable( 
'disable' );
+                       self.rightPointer.getView().getElement().draggable( 
'disable' );
+
+                       this.$element.find( '.revisions-container' ).animate(
+                               { scrollLeft: 
this.slider.getFirstVisibleRevisionIndex() * this.revisionWidth },
+                               duration,
+                               null,
+                               function () {
+                                       
self.leftPointer.getView().getElement().draggable( 'enable' );
+                                       
self.rightPointer.getView().getElement().draggable( 'enable' );
+                               }
+                       );
+
                        this.leftPointer.getView().slideToSideOrPosition( this, 
duration );
                        this.rightPointer.getView().slideToSideOrPosition( 
this, duration );
                },

-- 
To view, visit https://gerrit.wikimedia.org/r/288050
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I46add92298ac41b06437eef59f33a0ee64c4ccf0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to