VolkerE has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288100
Change subject: MediaWiki theme: SelectFileWidget not-supported style aligned
......................................................................
MediaWiki theme: SelectFileWidget not-supported style aligned
Not-supported style of SelectFileWidget aligned between single-line widgets and
ones with drop area.
Also hiding dropLabel on disabled instances and easifying code.
Bug: T133245
Change-Id: I00a8877fdf38d684fbad051c517b3498c3f77b97
---
M src/styles/widgets/SelectFileWidget.less
M src/themes/mediawiki/widgets.less
2 files changed, 19 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/00/288100/1
diff --git a/src/styles/widgets/SelectFileWidget.less
b/src/styles/widgets/SelectFileWidget.less
index e70a2b9..759b048 100644
--- a/src/styles/widgets/SelectFileWidget.less
+++ b/src/styles/widgets/SelectFileWidget.less
@@ -131,10 +131,6 @@
&-empty .oo-ui-selectFileWidget-dropTarget {
- .oo-ui-selectFileWidget-dropLabel {
- display: block;
- }
-
.oo-ui-selectFileWidget-thumbnail,
.oo-ui-selectFileWidget-info {
display: none;
@@ -160,6 +156,12 @@
}
}
+ &-empty.oo-ui-widget-enabled {
+ .oo-ui-selectFileWidget-dropLabel {
+ display: block;
+ }
+ }
+
&-empty.oo-ui-widget-disabled,
&-notsupported {
.oo-ui-selectFileWidget-dropTarget,
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index 76a594c..da00318 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -225,6 +225,7 @@
}
}
+ &-notsupported,
&.oo-ui-widget-disabled {
.oo-ui-selectFileWidget-info {
background-color: @background-color-disabled;
@@ -275,23 +276,22 @@
}
}
- // No close, no indicator:
&-empty,
&-notsupported {
+ // No close, no indicator:
.oo-ui-selectFileWidget-info {
.oo-ui-selectFileWidget-label {
right: 0.5em;
}
}
- }
- // No close, with indicator:
- &-empty.oo-ui-indicatorElement,
- &-notsupported.oo-ui-indicatorElement {
- .oo-ui-selectFileWidget-info {
- .oo-ui-selectFileWidget-label {
- right: 2em;
- padding-left: 0;
+ // No close, with indicator:
+ &.oo-ui-indicatorElement {
+ .oo-ui-selectFileWidget-info {
+ .oo-ui-selectFileWidget-label {
+ right: 2em;
+ padding-left: 0;
+ }
}
}
}
@@ -329,6 +329,10 @@
background-color: #eee;
border-style: dashed;
}
+
+ .oo-ui-widget-disabled .oo-ui-selectFileWidget-dropLabel {
+ display: none;
+ }
}
.theme-oo-ui-inputWidget () {
--
To view, visit https://gerrit.wikimedia.org/r/288100
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00a8877fdf38d684fbad051c517b3498c3f77b97
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
