jenkins-bot has submitted this change and it was merged.
Change subject: ve.ui.MWParameterPage: Remove non-working 'focus' handler
......................................................................
ve.ui.MWParameterPage: Remove non-working 'focus' handler
This element is a plain `<div>` with no tabindex, and therefore can't
be focussed. jQuery 'focus' events don't bubble, either, which would
otherwise allow focus events on children to fire this handler.
Change-Id: I68cb7d3bac143565c0a1bdb988312233b2d13ccd
---
M modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Alex Monk: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
b/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
index d9c403a..caf29fb 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWParameterPage.js
@@ -105,8 +105,7 @@
);
this.$more
.addClass( 've-ui-mwParameterPage-more' )
- .append( this.addButton.$element )
- .focus( this.onAddButtonFocus.bind( this ) );
+ .append( this.addButton.$element );
this.$element
.addClass( 've-ui-mwParameterPage' )
.append( this.$info, this.$field, this.$actions, this.$more );
--
To view, visit https://gerrit.wikimedia.org/r/287994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68cb7d3bac143565c0a1bdb988312233b2d13ccd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
