Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288110
Change subject: Fix deactivating VE after user explicitly decideas to discard
changes
......................................................................
Fix deactivating VE after user explicitly decideas to discard changes
Bug: T134794
Change-Id: Idf1941793317a6aff9fe57082b85e3ebff0c72b4
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/10/288110/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
index 1a889ac..1debd0b 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
@@ -499,7 +499,7 @@
opened.then( function ( closing ) {
closing.then( function ( data ) {
if ( data && data.action === 'discard'
) {
- this.emit( 'deactivate' );
+ target.emit( 'deactivate' );
target.cancel( trackMechanism );
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/288110
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf1941793317a6aff9fe57082b85e3ebff0c72b4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
