Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/288119
Change subject: Upgrade HockeyApp to v4.0.1 ...................................................................... Upgrade HockeyApp to v4.0.1 Upgrade the HockeyApp SDK[0] and enable user metrics[1]. [0] https://github.com/bitstadium/HockeySDK-Android/releases/tag/4.0.1 [1] https://www.hockeyapp.net/features/user-metrics/ Change-Id: I595e77f5f9f3c88b8c7b8762788de62f0e137867 --- M app/build.gradle M app/src/androidTest/java/org/wikipedia/test/TranslationTests.java M app/src/main/java/org/wikipedia/page/PageActivity.java 3 files changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/19/288119/1 diff --git a/app/build.gradle b/app/build.gradle index 19f01f8..bbd6b31 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -184,7 +184,7 @@ compile('com.mapbox.mapboxsdk:mapbox-android-sdk:4.0.0@aar') { transitive = true } - compile 'net.hockeyapp.android:HockeySDK:3.7.0' + compile 'net.hockeyapp.android:HockeySDK:4.0.1' compile 'org.apache.commons:commons-lang3:3.4' apt "com.jakewharton:butterknife-compiler:$butterKnifeVersion" diff --git a/app/src/androidTest/java/org/wikipedia/test/TranslationTests.java b/app/src/androidTest/java/org/wikipedia/test/TranslationTests.java index a817bea..e15bccf 100644 --- a/app/src/androidTest/java/org/wikipedia/test/TranslationTests.java +++ b/app/src/androidTest/java/org/wikipedia/test/TranslationTests.java @@ -231,7 +231,8 @@ // TODO: remove the following line as part of T91971. || name.equals("app_store_description") // Required after upgrading Support Libraries from v23.0.1 to v23.1.0. - || name.equals("character_counter_pattern")) { + || name.equals("character_counter_pattern") + || name.startsWith("hockeyapp_")) { continue; } diff --git a/app/src/main/java/org/wikipedia/page/PageActivity.java b/app/src/main/java/org/wikipedia/page/PageActivity.java index b6aa08f..1fa1bc8 100644 --- a/app/src/main/java/org/wikipedia/page/PageActivity.java +++ b/app/src/main/java/org/wikipedia/page/PageActivity.java @@ -81,6 +81,8 @@ import android.widget.ProgressBar; import android.widget.TextView; +import net.hockeyapp.android.metrics.MetricsManager; + import static org.wikipedia.util.DeviceUtil.isBackKeyUp; import static org.wikipedia.util.DeviceUtil.hideSoftKeyboard; import static org.wikipedia.util.UriUtil.visitInExternalBrowser; @@ -193,6 +195,7 @@ public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); app = (WikipediaApp) getApplicationContext(); + MetricsManager.register(this, app); app.checkCrashes(this); if (ApiUtil.hasKitKat()) { -- To view, visit https://gerrit.wikimedia.org/r/288119 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I595e77f5f9f3c88b8c7b8762788de62f0e137867 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
