Physikerwelt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/288148

Change subject: WIP: Handle SVGO errors
......................................................................

WIP: Handle SVGO errors

Change-Id: Ic0746221ad7343018df95174e74270992028e62a
---
M routes/mathoid.js
1 file changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mathoid 
refs/changes/48/288148/3

diff --git a/routes/mathoid.js b/routes/mathoid.js
index d5a5e12..698f9df 100644
--- a/routes/mathoid.js
+++ b/routes/mathoid.js
@@ -144,10 +144,15 @@
         }
 
         if (data.svg) {
-            svgo.optimize( data.svg, function ( result ) {
-                data.svg = result.data;
-                outputResponse();
-            } );
+            try {
+                svgo.optimize(data.svg, function (result) {
+                    data.svg = result.data;
+                    outputResponse();
+                });
+            } catch (e) {
+                console.log(JSON.stringify(e,null,2));
+               // TODO: @mobrovac how do we log?
+            }
         } else {
             outputResponse();
         }

-- 
To view, visit https://gerrit.wikimedia.org/r/288148
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0746221ad7343018df95174e74270992028e62a
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/services/mathoid
Gerrit-Branch: master
Gerrit-Owner: Physikerwelt <[email protected]>
Gerrit-Reviewer: Mobrovac <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to