Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288186
Change subject: Track usage of index feature in wbsetclaim API
......................................................................
Track usage of index feature in wbsetclaim API
Change-Id: Ic0eb410079c87c14274f3057837acbcf71a80f73
Fixes: T134882
---
M repo/includes/Api/SetClaim.php
1 file changed, 9 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/86/288186/1
diff --git a/repo/includes/Api/SetClaim.php b/repo/includes/Api/SetClaim.php
index 93f3d3c..66bdc49 100644
--- a/repo/includes/Api/SetClaim.php
+++ b/repo/includes/Api/SetClaim.php
@@ -10,6 +10,7 @@
use Diff\Differ\OrderedListDiffer;
use InvalidArgumentException;
use LogicException;
+use MediaWiki\MediaWikiServices;
use OutOfBoundsException;
use UsageException;
use Wikibase\ChangeOp\StatementChangeOpFactory;
@@ -143,17 +144,20 @@
$summary = $this->getSummary( $params, $statement,
$entity->getStatements() );
- $changeop = $this->statementChangeOpFactory->newSetStatementOp(
- $statement,
- isset( $params['index'] ) ? $params['index'] : null
- );
-
+ $index = isset( $params['index'] ) ? $params['index'] : null;
+ $changeop = $this->statementChangeOpFactory->newSetStatementOp(
$statement, $index );
$this->modificationHelper->applyChangeOp( $changeop, $entity,
$summary );
$status = $this->entitySavingHelper->attemptSaveEntity(
$entity, $summary, EDIT_UPDATE );
$this->resultBuilder->addRevisionIdFromStatusToResult( $status,
'pageinfo' );
$this->resultBuilder->markSuccess();
$this->resultBuilder->addStatement( $statement );
+
+ $stats =
MediaWikiServices::getInstance()->getStatsdDataFactory();
+ $stats->increment( 'wikibase.repo.api.wbsetclaim.total' );
+ if ( $index !== null ) {
+ $stats->increment( 'wikibase.repo.api.wbsetclaim.index'
);
+ }
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/288186
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0eb410079c87c14274f3057837acbcf71a80f73
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
