jenkins-bot has submitted this change and it was merged. Change subject: Clean-up constants and global functions (and extent tests) ......................................................................
Clean-up constants and global functions (and extent tests) + Split global functions from global constants + Load Setup with root file and not with settings file + Add test to safeguard from uninitialized global functions + Add test to check some of the constants (this is more to ensure that constants are loaded before any other funtion) Change-Id: I8b9ea9139c4856f4ee58ed4a8f3d237944a182cd --- M SemanticMediaWiki.hooks.php M SemanticMediaWiki.php M SemanticMediaWiki.settings.php M includes/Defines.php R includes/GlobalFunctions.php R includes/Setup.php A tests/phpunit/includes/DefinesTest.php M tests/phpunit/includes/GlobalFunctionsTest.php 8 files changed, 209 insertions(+), 86 deletions(-) Approvals: Jeroen De Dauw: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/44969 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b9ea9139c4856f4ee58ed4a8f3d237944a182cd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Mwjames <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
