jenkins-bot has submitted this change and it was merged.
Change subject: Use better names for hook methods
......................................................................
Use better names for hook methods
Change-Id: Ica485941221a13c3356909a06f7e1cd8e3e864d0
---
M extension.json
M includes/ContributorsHooks.php
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 157dfb7..80de3a9 100644
--- a/extension.json
+++ b/extension.json
@@ -33,10 +33,10 @@
"ContributorsHooks::invalidateCache"
],
"SkinTemplateBuildNavUrlsNav_urlsAfterPermalink": [
- "ContributorsHooks::navigation"
+
"ContributorsHooks::onSkinTemplateBuildNavUrlsNav_urlsAfterPermalink"
],
"SkinTemplateToolboxEnd": [
- "ContributorsHooks::toolbox"
+ "ContributorsHooks::onSkinTemplateToolboxEnd"
],
"ParserFirstCallInit": [
"ContributorsHooks::setupParserFunction"
diff --git a/includes/ContributorsHooks.php b/includes/ContributorsHooks.php
index 3a4fa3b..a026fb1 100644
--- a/includes/ContributorsHooks.php
+++ b/includes/ContributorsHooks.php
@@ -75,7 +75,12 @@
*
* @return bool
*/
- public static function navigation( &$skintemplate, &$nav_urls, &$oldid,
&$revid ) {
+ public static function onSkinTemplateBuildNavUrlsNav_urlsAfterPermalink(
+ &$skintemplate,
+ &$nav_urls,
+ &$oldid,
+ &$revid
+ ) {
if ( $skintemplate->getTitle()->getNamespace() === NS_MAIN &&
$revid !== 0 ) {
$nav_urls['contributors'] = array(
'text' => $skintemplate->msg(
'contributors-toolbox' ),
@@ -92,7 +97,7 @@
*
* @return bool
*/
- public static function toolbox( &$monobook ) {
+ public static function onSkinTemplateToolboxEnd( BaseTemplate
&$monobook ) {
if ( isset( $monobook->data['nav_urls']['contributors'] ) ) {
if (
$monobook->data['nav_urls']['contributors']['href'] == '' ) {
?><li id="t-iscontributors"><?php echo
$monobook->msg( 'contributors-toolbox' ); ?></li><?php
--
To view, visit https://gerrit.wikimedia.org/r/288103
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ica485941221a13c3356909a06f7e1cd8e3e864d0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Contributors
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: 01tonythomas <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Niharika29 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
