Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288537
Change subject: Correctly update locally cached seenTime
......................................................................
Correctly update locally cached seenTime
> Object.keys( wgEchoSeenTime );
["alert", "message", "m", "e", "s", "a", "g"]
Bug: T134854
Change-Id: I167e0eba1bad61a683f36218d2c90235f285a3c2
---
M modules/viewmodel/mw.echo.dm.NotificationsModel.js
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/37/288537/1
diff --git a/modules/viewmodel/mw.echo.dm.NotificationsModel.js
b/modules/viewmodel/mw.echo.dm.NotificationsModel.js
index 7ef866c..039800e 100644
--- a/modules/viewmodel/mw.echo.dm.NotificationsModel.js
+++ b/modules/viewmodel/mw.echo.dm.NotificationsModel.js
@@ -297,9 +297,9 @@
// Normalize if using 'all'
types = type === 'all' ? [ 'alert', 'message' ] : [ type ];
- for ( i = 0; i < type.length; i++ ) {
+ for ( i = 0; i < types.length; i++ ) {
// Update all types
- this.seenTime[ type[ i ] ] = time;
+ this.seenTime[ types[ i ] ] = time;
}
};
--
To view, visit https://gerrit.wikimedia.org/r/288537
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I167e0eba1bad61a683f36218d2c90235f285a3c2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
