Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288646
Change subject: Rename / remove mention of "wikidata" in PageDataBuilder
......................................................................
Rename / remove mention of "wikidata" in PageDataBuilder
Make it generic and say "Wikibase" instead and improve
the code comments.
Change-Id: If4cd6a3b11eb05082912258e6822f37f1542a5d6
---
M includes/BuildDocument/PageDataBuilder.php
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch
refs/changes/46/288646/1
diff --git a/includes/BuildDocument/PageDataBuilder.php
b/includes/BuildDocument/PageDataBuilder.php
index 7793df5..04a1e3d 100644
--- a/includes/BuildDocument/PageDataBuilder.php
+++ b/includes/BuildDocument/PageDataBuilder.php
@@ -48,7 +48,7 @@
$this->headings();
$this->outgoingLinks();
$this->templates();
- $this->wikidataInfo();
+ $this->setWikibaseItemId();
}
// All content types have a language
@@ -147,9 +147,11 @@
}
/**
- * Add wikidata information to the index if wikibase is installed on
this wiki.
+ * Add item id of a page's connected Wikibase item (if available)
+ *
+ * @todo move this to Wikibase
*/
- private function wikidataInfo() {
+ private function setWikibaseItemId() {
$wikibaseItem = $this->parserOutput->getProperty(
'wikibase_item' );
if ( $wikibaseItem !== false ) {
$this->doc->set( 'wikibase_item', $wikibaseItem );
--
To view, visit https://gerrit.wikimedia.org/r/288646
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4cd6a3b11eb05082912258e6822f37f1542a5d6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
