IAlex has submitted this change and it was merged. Change subject: Remove references to non-existent 'execute' right in Title.php ......................................................................
Remove references to non-existent 'execute' right in Title.php The permission checks in Title will automatically fail any check against a special page, except for read, execute and createaccount. However, execute is not a right. It is not mentioned in any other MW file (or extension for that matter). It is neither in the list of core user rights in User.php, nor does it have a system msg If someone wants to check if they can run a special page, they should be doing a 'read' check. Note: The check in question was added in bc23aede55e back in 2008 I'm unsure if it is better to just leave it alone, or remove it. However, its presence could cause some confusion, hence this commit. Additionally I was unsure if this justified a release notes entry. Change-Id: I9cf2b0424b9cb189ac122b8274ec681302f560f7 --- M includes/Title.php M tests/phpunit/includes/TitlePermissionTest.php 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: IAlex: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/42237 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cf2b0424b9cb189ac122b8274ec681302f560f7 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Brian Wolff <[email protected]> Gerrit-Reviewer: Brian Wolff <[email protected]> Gerrit-Reviewer: IAlex <[email protected]> Gerrit-Reviewer: Werdna <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
