TheDJ has uploaded a new change for review.
https://gerrit.wikimedia.org/r/289308
Change subject: Fix the disablecontrols option for videojs
......................................................................
Fix the disablecontrols option for videojs
This should disable specific controls, not all of the controls.
Hope to deprecate this in the future (T135537).
Bug: T135516
Change-Id: I013f68df6a696d6f3f6d8a2d9fbc29703b6275a9
---
M TimedMediaTransformOutput.php
1 file changed, 4 insertions(+), 7 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/08/289308/1
diff --git a/TimedMediaTransformOutput.php b/TimedMediaTransformOutput.php
index 31008e4..c32af54 100644
--- a/TimedMediaTransformOutput.php
+++ b/TimedMediaTransformOutput.php
@@ -443,10 +443,6 @@
unset( $mediaAttr['height'] );
unset( $mediaAttr['poster'] );
}
-
- if ( $this->disablecontrols ) {
- $mediaAttr[ 'controls' ] = false;
- }
} else {
$mediaAttr['style'] = "width:{$width}";
@@ -456,10 +452,11 @@
// MediaWiki uses the kSkin class
$mediaAttr['class'] = 'kskin';
+ }
- if ( $this->disablecontrols ) {
- $mediaAttr[ 'data-disablecontrols' ] =
$this->disablecontrols;
- }
+ // Used by Score extension and to disable specific controls
from wikicode
+ if ( $this->disablecontrols ) {
+ $mediaAttr[ 'data-disablecontrols' ] =
$this->disablecontrols;
}
if ( $this->file ) {
--
To view, visit https://gerrit.wikimedia.org/r/289308
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I013f68df6a696d6f3f6d8a2d9fbc29703b6275a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
