Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/289344
Change subject: WIP: Experiment with collapsing references by default
......................................................................
WIP: Experiment with collapsing references by default
Change-Id: I5ebe531a897524872a05ab44f6e82985cd9ecd2b
---
M resources/mobile.toggle/toggle.js
1 file changed, 6 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/44/289344/1
diff --git a/resources/mobile.toggle/toggle.js
b/resources/mobile.toggle/toggle.js
index 9a7ed17..72f02af 100644
--- a/resources/mobile.toggle/toggle.js
+++ b/resources/mobile.toggle/toggle.js
@@ -128,7 +128,7 @@
* @ignore
*/
Toggler.prototype.toggle = function ( $heading ) {
- var indicator, $content,
+ var indicator,
wasExpanded = $heading.is( '.open-block' ),
page = $heading.data( 'page' ),
sectionId = $heading.data( 'section-number' );
@@ -143,16 +143,14 @@
indicator = new Icon( arrowOptions ).prependTo( $heading );
$heading.data( 'indicator', indicator );
- $content = $heading.next();
- $content
+ $heading.next()
.toggleClass( 'open-block' )
.attr( {
'aria-pressed': !wasExpanded,
'aria-expanded': !wasExpanded
} );
- M.emit( 'section-toggled', wasExpanded, sectionId,
- $content.attr( 'data-reference-section' ) );
+ M.emit( 'section-toggled', wasExpanded, sectionId );
if ( !browser.isWideScreen() ) {
storeSectionToggleState( $heading, page );
@@ -217,7 +215,7 @@
* @constructor
*/
Toggler.prototype._enable = function ( $container, prefix, page,
isClosed ) {
- var tagName, expandSections, indicator, $content,
+ var tagName, expandSections, indicator,
$firstHeading,
self = this,
collapseSectionsByDefault = mw.config.get(
'wgMFCollapseSectionsByDefault' );
@@ -241,8 +239,6 @@
// Be sure there is a div wrapping the section content.
// Otherwise, collapsible sections for this page is not
enabled.
if ( $heading.next().is( 'div' ) ) {
- $content = $heading.next( 'div' );
- isReferenceSection = Boolean( $content.attr(
'data-reference-section' ) );
$heading
.addClass( 'collapsible-heading ' )
.data( 'section-number', i )
@@ -269,7 +265,7 @@
indicator.prependTo( $heading );
}
$heading.data( 'indicator', indicator.$el );
- $content
+ $heading.next( 'div' )
.addClass( 'collapsible-block' )
.eq( 0 )
.attr( {
@@ -282,7 +278,7 @@
} );
enableKeyboardActions( self, $heading );
- if ( !isReferenceSection && ( !isClosed &&
browser.isWideScreen() || expandSections ) ) {
+ if ( !isClosed && browser.isWideScreen() ||
expandSections ) {
// Expand sections by default on wide
screen devices or if the expand sections setting is set
self.toggle.call( self, $heading );
}
--
To view, visit https://gerrit.wikimedia.org/r/289344
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ebe531a897524872a05ab44f6e82985cd9ecd2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
