jenkins-bot has submitted this change and it was merged.
Change subject: Set empty lat lon to NULL in monuments_all (and wlpa_all)
......................................................................
Set empty lat lon to NULL in monuments_all (and wlpa_all)
Only changes when both lat and lon are 0 to ensure no valid
coordinates are discarded (sorry NULL island).
Bug: T39422
Change-Id: I8b0758e0f8cd4e365da5283cd9be8ddd695645c2
---
M erfgoedbot/sql/fill_table_monuments_all.sql
M erfgoedbot/sql/fill_table_wlpa_all.sql
2 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
Jean-Frédéric: Looks good to me, approved
jenkins-bot: Verified
diff --git a/erfgoedbot/sql/fill_table_monuments_all.sql
b/erfgoedbot/sql/fill_table_monuments_all.sql
index fd39336..5d1cf9b 100644
--- a/erfgoedbot/sql/fill_table_monuments_all.sql
+++ b/erfgoedbot/sql/fill_table_monuments_all.sql
@@ -2740,6 +2740,11 @@
FROM `monuments_za_(en)`;
-- UPDATE `monuments_all_tmp` SET lat_int = ROUND(lat * @granularity), lon_int
= ROUND(lon * @granularity);
+/* when both lat and lon = 0 something went wrong */
+UPDATE `monuments_all_tmp`
+SET `lat`=NULL, `lon`=NULL, `lat_int`=NULL, `lon_int`=NULL
+WHERE `lat`=0 AND `lon`=0;
+
DROP TABLE IF EXISTS `monuments_all`;
ALTER TABLE `monuments_all_tmp` RENAME TO `monuments_all`;
diff --git a/erfgoedbot/sql/fill_table_wlpa_all.sql
b/erfgoedbot/sql/fill_table_wlpa_all.sql
index dfa6a2f..64781a1 100644
--- a/erfgoedbot/sql/fill_table_wlpa_all.sql
+++ b/erfgoedbot/sql/fill_table_wlpa_all.sql
@@ -176,6 +176,11 @@
-- UPDATE `wlpa_all_tmp` SET lat_int = ROUND(lat * @granularity), lon_int =
ROUND(lon * @granularity);
+/* when both lat and lon = 0 something went wrong */
+UPDATE `wlpa_all_tmp`
+SET `lat`=NULL, `lon`=NULL, `lat_int`=NULL, `lon_int`=NULL
+WHERE `lat`=0 AND `lon`=0;
+
DROP TABLE IF EXISTS `wlpa_all`;
ALTER TABLE `wlpa_all_tmp` RENAME TO `wlpa_all`;
--
To view, visit https://gerrit.wikimedia.org/r/289359
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b0758e0f8cd4e365da5283cd9be8ddd695645c2
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/heritage
Gerrit-Branch: master
Gerrit-Owner: Lokal Profil <[email protected]>
Gerrit-Reviewer: Jean-Frédéric <[email protected]>
Gerrit-Reviewer: Multichill <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
