jenkins-bot has submitted this change and it was merged. Change subject: Remove unnecessary HistoryEntityAction subclasses ......................................................................
Remove unnecessary HistoryEntityAction subclasses Change-Id: I6e15b324e0da3a2f26cd0154f16e86e2ee338956 --- D repo/includes/Actions/HistoryItemAction.php D repo/includes/Actions/HistoryPropertyAction.php M repo/includes/Content/ItemHandler.php M repo/includes/Content/PropertyHandler.php 4 files changed, 4 insertions(+), 34 deletions(-) Approvals: Jonas Kress (WMDE): Looks good to me, approved jenkins-bot: Verified diff --git a/repo/includes/Actions/HistoryItemAction.php b/repo/includes/Actions/HistoryItemAction.php deleted file mode 100644 index 633f179..0000000 --- a/repo/includes/Actions/HistoryItemAction.php +++ /dev/null @@ -1,15 +0,0 @@ -<?php - -namespace Wikibase; - -/** - * Handles the history action for Wikibase items. - * - * @since 0.1 - * - * @license GPL-2.0+ - * @author John Erling Blad < [email protected] > - */ -class HistoryItemAction extends HistoryEntityAction { - -} diff --git a/repo/includes/Actions/HistoryPropertyAction.php b/repo/includes/Actions/HistoryPropertyAction.php deleted file mode 100644 index b2572b3..0000000 --- a/repo/includes/Actions/HistoryPropertyAction.php +++ /dev/null @@ -1,15 +0,0 @@ -<?php - -namespace Wikibase; - -/** - * Handles the history action for Wikibase properties. - * - * @since 0.1 - * - * @license GPL-2.0+ - * @author John Erling Blad < [email protected] > - */ -class HistoryPropertyAction extends HistoryEntityAction { - -} diff --git a/repo/includes/Content/ItemHandler.php b/repo/includes/Content/ItemHandler.php index 8638730..cb51f8f 100644 --- a/repo/includes/Content/ItemHandler.php +++ b/repo/includes/Content/ItemHandler.php @@ -10,7 +10,7 @@ use Wikibase\DataModel\Entity\EntityIdParser; use Wikibase\EditItemAction; use Wikibase\EntityContent; -use Wikibase\HistoryItemAction; +use Wikibase\HistoryEntityAction; use Wikibase\ItemContent; use Wikibase\Lib\Store\EntityContentDataCodec; use Wikibase\Lib\Store\SiteLinkStore; @@ -88,7 +88,7 @@ */ public function getActionOverrides() { return array( - 'history' => HistoryItemAction::class, + 'history' => HistoryEntityAction::class, 'view' => ViewItemAction::class, 'edit' => EditItemAction::class, 'submit' => SubmitItemAction::class, diff --git a/repo/includes/Content/PropertyHandler.php b/repo/includes/Content/PropertyHandler.php index 432e494..6f5723b 100644 --- a/repo/includes/Content/PropertyHandler.php +++ b/repo/includes/Content/PropertyHandler.php @@ -10,7 +10,7 @@ use Wikibase\DataModel\Entity\PropertyId; use Wikibase\EditPropertyAction; use Wikibase\EntityContent; -use Wikibase\HistoryPropertyAction; +use Wikibase\HistoryEntityAction; use Wikibase\Lib\Store\EntityContentDataCodec; use Wikibase\PropertyContent; use Wikibase\PropertyInfoBuilder; @@ -97,7 +97,7 @@ */ public function getActionOverrides() { return array( - 'history' => HistoryPropertyAction::class, + 'history' => HistoryEntityAction::class, 'view' => ViewPropertyAction::class, 'edit' => EditPropertyAction::class, 'submit' => SubmitPropertyAction::class, -- To view, visit https://gerrit.wikimedia.org/r/289376 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e15b324e0da3a2f26cd0154f16e86e2ee338956 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Adrian Heine <[email protected]> Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
