Henning Snater has submitted this change and it was merged. Change subject: (minor) moved jQuery.TemplatedWidget template related fields into options ......................................................................
(minor) moved jQuery.TemplatedWidget template related fields into options the template options have been fields in the prototype before. It makes kind of sense to make them available in the options though. An issue with having 'templateShortCuts' as a field was that inheritance would not be possible with the jQuery Widget system since only options will get a true copy by $.widget while other objects will be modified on the base prototype. Our workaround for this only worked for one level of inheritance (doing the copy manually in the prototype's constructor, can't define the constructor of the new prototype created by jQuery.widget() though). Change-Id: I18a62c2bf1bfd4c92ba53fd7775948009d16b130 --- M lib/resources/jquery.ui/jquery.ui.TemplatedWidget.js M lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js M lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.js 4 files changed, 70 insertions(+), 89 deletions(-) Approvals: Henning Snater: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/45119 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I18a62c2bf1bfd4c92ba53fd7775948009d16b130 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <[email protected]> Gerrit-Reviewer: Henning Snater <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
