Hashar has submitted this change and it was merged. Change subject: removes NoSpaceAfterCast ......................................................................
removes NoSpaceAfterCast NoSpaceAfterCast conflicts with SpaceAfterCast check. Being bold I choose the one that require a space, hence instead of: $int = (int)$foo; We should write: $int = (int) $foo; I believe we like spaces, so that should not cause too much troubles. Change-Id: If4b810d4dec61af22b811f39c345637ece6db7e7 --- M MediaWiki/ruleset.xml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/45140 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4b810d4dec61af22b811f39c345637ece6db7e7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/codesniffer Gerrit-Branch: master Gerrit-Owner: Hashar <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
