Hashar has submitted this change and it was merged.
Change subject: no space after cast instruction
......................................................................
no space after cast instruction
Checked mediawiki/core includes directory for the presence of a space
after a casting instruction. The command used was:
phpcsmw -v -s \
--report-summary \
--sniffs=Generic.Formatting.NoSpaceAfterCast,Generic.Formatting.SpaceAfterCast \
./includes
Errors per sniff:
354 Generic.Formatting.SpaceAfterCast.NoSpace
60 Generic.Formatting.NoSpaceAfterCast.SpaceFound
So I guess we want to keep the Generic.Formatting.SpaceAfterCast.NoSpace
which ensure there is no whitespace.
Reverts commit a37afbbc59530c25b7c4b6012bdead8ae47b53df
Change-Id: Icaa21217be6a0bb27c0bdc239fd61824fc2a426e
---
M MediaWiki/ruleset.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Demon: Looks good to me, approved
Hashar: Verified
--
To view, visit https://gerrit.wikimedia.org/r/45142
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaa21217be6a0bb27c0bdc239fd61824fc2a426e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/tools/codesniffer
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
