Hashar has submitted this change and it was merged. Change subject: phpcs ran on deleted file ......................................................................
phpcs ran on deleted file `git diff --name-only` shows up any file added, modified or deleted. We do not want to run phpcs on a deleted file since it will not exist in the workspace and a stracktrace will be thrown. Instead use --name-status which shows up a A,M,D in front of each file. Resulting command is: git diff --name-status HEAD^ | egrep -v '^D'| cut -f2 Change-Id: I6d91d0429966c957a76fc35f65c52c72eff1f17d --- M macro.yaml 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Hashar: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/45143 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6d91d0429966c957a76fc35f65c52c72eff1f17d Gerrit-PatchSet: 1 Gerrit-Project: integration/jenkins-job-builder-config Gerrit-Branch: master Gerrit-Owner: Hashar <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
