Catrope has submitted this change and it was merged. Change subject: (bug 31849) API imageinfo correctly handle redirects ......................................................................
(bug 31849) API imageinfo correctly handle redirects RepoGroup::singleton()->findFiles() returns an associative array mapping the redirect *target* to the image object; the image object refers back to the original title queried. If a redirect and its target are both queried, RepoGroup::singleton()->findFiles() will return an entry for the target title only, mapping to an image object that may have getOriginalTitle() returning the redirect. If this happens, prop=imageinfo will never see an entry for which getOriginalTitle()->isRedirect() is false and so will not return any information about the image. The fix is to ignore getOriginalTitle() entirely. Instead, we just go through each of our queried titles and see if we got any result back. Note this automatically handles a "redirects=1" query correctly, since in that case any local redirect will already have been followed before we ever got the list of titles to query. Change-Id: I0b2982901e2dc4491e2933291fd97697b2a622a9 --- M RELEASE-NOTES-1.21 M includes/api/ApiQueryImageInfo.php 2 files changed, 10 insertions(+), 5 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/40562 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0b2982901e2dc4491e2933291fd97697b2a622a9 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Anomie <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Anomie <[email protected]> Gerrit-Reviewer: Catrope <[email protected]> Gerrit-Reviewer: MaxSem <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: btongminh <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
