jenkins-bot has submitted this change and it was merged.
Change subject: Cleanup to ImagePage::openShowImage()
......................................................................
Cleanup to ImagePage::openShowImage()
- Removed useless $showLink variable and related check since the variable is
always defined to true
- Moved $linktext up so that there's no need to use a temporary variable to
modify it
- Moved $longDesc down where it's used
- Change "else { if ( ... ) { } }" to elseif for better clarity
Change-Id: I65dcbb76c7f0a0441a6420e76affe797a3dc9c45
---
M includes/ImagePage.php
1 file changed, 25 insertions(+), 34 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
btongminh: Looks good to me, but someone else must approve
jenkins-bot: Verified
--
To view, visit https://gerrit.wikimedia.org/r/33116
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65dcbb76c7f0a0441a6420e76affe797a3dc9c45
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: btongminh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
