Dzahn has submitted this change and it was merged.
Change subject: zookeeper: fix lint warnings
......................................................................
zookeeper: fix lint warnings
Change-Id: Iecad5e53293cbf6e40ee22ddac89d09a78bca9b5
---
M manifests/jmxtrans.pp
M manifests/server.pp
M tests/server.pp
M tests/zookeeper.pp
4 files changed, 16 insertions(+), 8 deletions(-)
Approvals:
jenkins-bot: Verified
Dzahn: Looks good to me, approved
diff --git a/manifests/jmxtrans.pp b/manifests/jmxtrans.pp
index 3d82d35..cc3cafb 100644
--- a/manifests/jmxtrans.pp
+++ b/manifests/jmxtrans.pp
@@ -35,8 +35,8 @@
# query for metrics from zookeeper's JVM
jmxtrans::metrics::jvm { $jmx:
- outfile => $outfile,
- ganglia => $ganglia,
- graphite => $graphite,
+ outfile => $outfile,
+ ganglia => $ganglia,
+ graphite => $graphite,
}
-}
\ No newline at end of file
+}
diff --git a/manifests/server.pp b/manifests/server.pp
index 0db023c..680eb2a 100644
--- a/manifests/server.pp
+++ b/manifests/server.pp
@@ -50,8 +50,8 @@
content => $myid,
}
file { "${::zookeeper::data_dir}/myid":
- ensure => 'link',
- target => '/etc/zookeeper/conf/myid',
+ ensure => 'link',
+ target => '/etc/zookeeper/conf/myid',
}
service { 'zookeeper':
diff --git a/tests/server.pp b/tests/server.pp
index 67808d1..4f7c3d2 100644
--- a/tests/server.pp
+++ b/tests/server.pp
@@ -1,7 +1,11 @@
$fqdn = 'zoo1.domain.org'
class { 'zookeeper':
- hosts => { 'zoo1.domain.org' => 1, 'zoo2.domain.org' => 2,
'zoo3.domain.org' => 3 },
+ hosts => {
+ 'zoo1.domain.org' => 1,
+ 'zoo2.domain.org' => 2,
+ 'zoo3.domain.org' => 3
+ },
data_dir => '/var/lib/zookeeper',
}
diff --git a/tests/zookeeper.pp b/tests/zookeeper.pp
index fee4b07..a2b4abc 100644
--- a/tests/zookeeper.pp
+++ b/tests/zookeeper.pp
@@ -1,6 +1,10 @@
$fqdn = 'zoo1.domain.org'
class { 'zookeeper':
- hosts => { 'zoo1.domain.org' => 1, 'zoo2.domain.org' => 2,
'zoo3.domain.org' => 3 },
+ hosts => {
+ 'zoo1.domain.org' => 1,
+ 'zoo2.domain.org' => 2,
+ 'zoo3.domain.org' => 3
+ },
data_dir => '/var/lib/zookeeper',
}
--
To view, visit https://gerrit.wikimedia.org/r/289979
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecad5e53293cbf6e40ee22ddac89d09a78bca9b5
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet/zookeeper
Gerrit-Branch: master
Gerrit-Owner: Dzahn <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Mschon <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
