Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290890
Change subject: Give language selection buttons more space
......................................................................
Give language selection buttons more space
Let them assume normal size with regular margin. In the rare case
that the buttons do not fit one line, it will not overflow to second
line and does not look ugly.
Bug: T136273
Change-Id: I26dd7745ac03e1b940348b318d74d0a2bd27e1a3
---
M resources/css/ext.uls.css
M resources/js/ext.uls.displaysettings.js
M resources/js/ext.uls.inputsettings.js
3 files changed, 8 insertions(+), 10 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/90/290890/1
diff --git a/resources/css/ext.uls.css b/resources/css/ext.uls.css
index faab31c..cf8037c 100644
--- a/resources/css/ext.uls.css
+++ b/resources/css/ext.uls.css
@@ -41,12 +41,10 @@
}
.uls-ui-languages button {
- width: 22%;
text-overflow: ellipsis;
- margin-right: 2%;
+ margin: 5px 15px 5px 0;
white-space: nowrap;
overflow: hidden;
- padding: 0.5em 0;
}
button.uls-more-languages {
diff --git a/resources/js/ext.uls.displaysettings.js
b/resources/js/ext.uls.displaysettings.js
index 494f854..1940084 100644
--- a/resources/js/ext.uls.displaysettings.js
+++ b/resources/js/ext.uls.displaysettings.js
@@ -38,14 +38,14 @@
// "Display language", title above the buttons row
'<div class="row">' +
- '<div class="eleven columns">' +
+ '<div class="twelve columns">' +
'<h4 data-i18n="ext-uls-display-settings-ui-language"></h4>' +
'</div>' +
'</div>' +
// UI languages buttons row
'<div class="row">' +
- '<div class="uls-ui-languages eleven columns">' +
+ '<div class="uls-ui-languages twelve columns">' +
'<p data-i18n="ext-uls-language-buttons-help"></p>' +
'</div>' +
'</div>' +
@@ -86,7 +86,7 @@
// Webfonts enabling checkbox with label
'<div class="row">' +
- '<div class="eleven columns">' +
+ '<div class="twelve columns">' +
'<div class="mw-ui-checkbox">' +
'<input type="checkbox" id="webfonts-enable-checkbox" />' +
'<label class="checkbox" for="webfonts-enable-checkbox" >' +
diff --git a/resources/js/ext.uls.inputsettings.js
b/resources/js/ext.uls.inputsettings.js
index d303a6b..8aaa4c5 100644
--- a/resources/js/ext.uls.inputsettings.js
+++ b/resources/js/ext.uls.inputsettings.js
@@ -30,19 +30,19 @@
// "Language for ime", title above the buttons row
'<div class="row enabled-only
uls-input-settings-languages-title">' +
- '<div class="eleven columns">' +
+ '<div class="twelve columns">' +
'<h4 data-i18n="ext-uls-input-settings-ui-language"></h4>' +
'</div>' +
'</div>' +
// UI languages buttons row
'<div class="row enabled-only">' +
- '<div class="uls-ui-languages eleven columns"></div>' +
+ '<div class="uls-ui-languages twelve columns"></div>' +
'</div>' +
// Web IMEs enabling chechbox with label
'<div class="row enabled-only">' +
- '<div class="eleven columns
uls-input-settings-inputmethods-list">' +
+ '<div class="twelve columns
uls-input-settings-inputmethods-list">' +
// "Input settings for language xyz" title
'<h4 class="ext-uls-input-settings-imes-title"></h4>' +
'</div>' +
@@ -50,7 +50,7 @@
// Disable IME system button
'<div class="row">' +
- '<div class="eleven columns
uls-input-settings-disable-info"></div>' +
+ '<div class="twelve columns
uls-input-settings-disable-info"></div>' +
'<div class="ten columns uls-input-settings-toggle">' +
'<button class="active mw-ui-constructive mw-ui-button
uls-input-toggle-button"></button>' +
'</div>' +
--
To view, visit https://gerrit.wikimedia.org/r/290890
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I26dd7745ac03e1b940348b318d74d0a2bd27e1a3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
