Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/290896

Change subject: contint: disable DNS lookup for castor rsyncd
......................................................................

contint: disable DNS lookup for castor rsyncd

The rsync server on castor is hit by the contintcloud disposable
instances. The wmflabs infrastructure does not always properly set the
DNS entry which causes /var/log/messages to be spammed by:

 forward name lookup for
 ci-trusty-wikimedia-x.contintcloud.eqiad.wmflabs failed:
   Name or service not known

From rsyncd.conf:

  forward lookup

  Controls whether the daemon performs a forward lookup on any hostname
  specified in an hosts allow/deny setting. By default this is enabled,
  allowing the use of an explicit hostname that would not be returned by
  reverse DNS of the connecting IP.

Since we do not rely on hosts allow/deny, disable the DNS forward lookup
entirely which would stop the log spam.

Bug: T136276
Change-Id: I88c9b2a52743427de6d4d8a53df6cb5424d239b4
---
M modules/role/manifests/ci/castor/server.pp
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/96/290896/1

diff --git a/modules/role/manifests/ci/castor/server.pp 
b/modules/role/manifests/ci/castor/server.pp
index 7314c72..822eeb5 100644
--- a/modules/role/manifests/ci/castor/server.pp
+++ b/modules/role/manifests/ci/castor/server.pp
@@ -5,7 +5,14 @@
     requires_realm( 'labs' )
 
     include role::labs::lvm::mnt
-    include rsync::server
+    class { 'rsync::server':
+        # Disable DNS lookup since wmflabs fails to set some for contintcloud
+        # and that is annoying in logs. That is solely needed for host
+        # allow/deny which we do not use. T136276
+        $rsyncd_conf = {
+            'forward lookup' => 'no',
+        }
+    }
 
     file { '/mnt/jenkins-workspace/caches':
         ensure  => directory,

-- 
To view, visit https://gerrit.wikimedia.org/r/290896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I88c9b2a52743427de6d4d8a53df6cb5424d239b4
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to