WMDE-leszek has submitted this change and it was merged.
Change subject: Fix bug that caused the most recent revision to never be
visible.
......................................................................
Fix bug that caused the most recent revision to never be visible.
Bug: T135739
Change-Id: I00e30a585b3a38da7e405f200356163b20358df9
---
M modules/ext.RevisionSlider.Slider.js
M tests/RevisionSlider.Slider.test.js
2 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
WMDE-leszek: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.RevisionSlider.Slider.js
b/modules/ext.RevisionSlider.Slider.js
index e98a7d3..ae1f352 100644
--- a/modules/ext.RevisionSlider.Slider.js
+++ b/modules/ext.RevisionSlider.Slider.js
@@ -48,7 +48,7 @@
},
isAtEnd: function () {
- return this.getLastVisibleRevisionIndex() ===
this.revisions.getLength() - 2 || this.revisions.getLength() <=
this.revisionsPerWindow;
+ return this.getLastVisibleRevisionIndex() ===
this.revisions.getLength() - 1 || this.revisions.getLength() <=
this.revisionsPerWindow;
},
setFirstVisibleRevisionIndex: function ( value ) {
@@ -56,7 +56,7 @@
},
slide: function ( direction ) {
- var highestPossibleFirstRev =
this.revisions.getLength() - 1 - this.revisionsPerWindow;
+ var highestPossibleFirstRev =
this.revisions.getLength() - this.revisionsPerWindow;
this.firstVisibleRevisionIndex += direction *
this.revisionsPerWindow;
this.firstVisibleRevisionIndex = Math.min(
this.firstVisibleRevisionIndex, highestPossibleFirstRev );
diff --git a/tests/RevisionSlider.Slider.test.js
b/tests/RevisionSlider.Slider.test.js
index 303376f..15b3b73 100644
--- a/tests/RevisionSlider.Slider.test.js
+++ b/tests/RevisionSlider.Slider.test.js
@@ -39,7 +39,7 @@
slider.setRevisionsPerWindow( 50 );
slider.slide( 1 );
- assert.equal( slider.getFirstVisibleRevisionIndex(), 24 );
+ assert.equal( slider.getFirstVisibleRevisionIndex(), 25 );
} );
QUnit.test( 'firstVisibleRevisionIndex cannot be lower than 0',
function ( assert ) {
--
To view, visit https://gerrit.wikimedia.org/r/289867
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00e30a585b3a38da7e405f200356163b20358df9
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: Jakob <jakob.warkot...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
