Jhernandez has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290913
Change subject: Use exchars instead of exsentences for the extract
......................................................................
Use exchars instead of exsentences for the extract
To avoid sentence parsing bugs in other languages.
Bug: T135824
Change-Id: Idf27f2fd18f7197e588c609eeb62ac8fc80626d7
---
M resources/ext.popups.renderer.article.js
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/13/290913/1
diff --git a/resources/ext.popups.renderer.article.js
b/resources/ext.popups.renderer.article.js
index 14ec6e9..aee0985 100644
--- a/resources/ext.popups.renderer.article.js
+++ b/resources/ext.popups.renderer.article.js
@@ -6,7 +6,8 @@
* @singleton
*/
var article = {},
- $window = $( window );
+ $window = $( window ),
+ CHARS = 525;
/**
* Size constants for popup images
@@ -55,7 +56,7 @@
formatversion: 2,
redirects: true,
exintro: true,
- exsentences: 5,
+ exchars: CHARS,
// there is an added geometric limit on
.mwe-popups-extract
// so that text does not overflow from the card
explaintext: true,
--
To view, visit https://gerrit.wikimedia.org/r/290913
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf27f2fd18f7197e588c609eeb62ac8fc80626d7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Jhernandez <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
