jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Less variable cleanup
......................................................................
Hygiene: Less variable cleanup
* Add some variables for things that should have variables
* Remove some unused variables
Change-Id: I0995142eef10639390d79de4c410a7b95fd13e39
---
M minerva.less/minerva.variables.less
M resources/skins.minerva.base.styles/pageactions.less
M resources/skins.minerva.tablet.styles/common.less
3 files changed, 4 insertions(+), 10 deletions(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/minerva.less/minerva.variables.less
b/minerva.less/minerva.variables.less
index 9494648..992724d 100644
--- a/minerva.less/minerva.variables.less
+++ b/minerva.less/minerva.variables.less
@@ -11,6 +11,8 @@
@rightDrawerWidth: 60%;
// Headings
+@firstHeadingFontSize: 2.6525em; // 42px
+@pageActionFontSize: 1.1em; // Icons are 24px square.
@fontSizeH1: 1.7em;
@fontSizeH2: 1.5em;
@fontSizeH3: 1.2em;
@@ -19,8 +21,6 @@
@contentMargin: 16px;
// old header
-// FIXME: Remove when mediawiki.ui buttons in stable
-@headerElementHeight: 30px;
@headerBorderBottom: #e3e3e3;
// new header
@@ -36,9 +36,6 @@
@grayMediumLight: @colorGray10;
@grayLight: @colorGray12;
@grayLightest: @colorGray14;
-
-// page actions
-@watchStarSize: 22px;
// colors
@chromeColor: #f2f2f2;
@@ -90,9 +87,6 @@
// note since content does not use view border box we have to include padding.
@contentMaxWidthTablet: @wgMFDeviceWidthDesktop - ( 2 * @contentPaddingTablet
);
@contentTopPadding: 1.6em;
-
-// calculated values
-@secondaryNavWidth: @headerElementHeight;
// calculated colors
@searchBoxColorTo: darken( @searchBoxColor, 2.75% );
diff --git a/resources/skins.minerva.base.styles/pageactions.less
b/resources/skins.minerva.base.styles/pageactions.less
index 0c8aea4..076cd6a 100644
--- a/resources/skins.minerva.base.styles/pageactions.less
+++ b/resources/skins.minerva.base.styles/pageactions.less
@@ -39,7 +39,7 @@
}
#page-actions {
- font-size: 1.1em; // Icons are 24px square.
+ font-size: @pageActionFontSize;
float: right;
border: none;
overflow: hidden;
diff --git a/resources/skins.minerva.tablet.styles/common.less
b/resources/skins.minerva.tablet.styles/common.less
index f4dba46..41476a3 100644
--- a/resources/skins.minerva.tablet.styles/common.less
+++ b/resources/skins.minerva.tablet.styles/common.less
@@ -40,7 +40,7 @@
#section_0 {
border-bottom: none;
padding: 0 0 7px 0;
- font-size: 2.6525em; // 42px
+ font-size: @firstHeadingFontSize;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/290788
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0995142eef10639390d79de4c410a7b95fd13e39
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
