jenkins-bot has submitted this change and it was merged.
Change subject: Add a gutter for header to avoid page action overlap
......................................................................
Add a gutter for header to avoid page action overlap
With the change in I39668a9528a9f3906509014ca7d2c1ba0f2ebdbb
it was not considered what should happen to long titles.
This change ensures that page actions and header will never overlap
with the power of MATHEMATICS.
Note in certain circumstances the gap may be bigger than normal due
to a different number of 3 icons:
* Languages button is disabled
* Non-JavaScript editing is enabled and user has JS disabled
* User has JavaScript disabled
Bug: T135646
Change-Id: Id97abc53c5e49d78d5cadadbf35a07670102f658
Depends-On: Ic544ce4394834757a3bb007a91369e01af2d0b7d
---
M resources/skins.minerva.beta.styles/pageactions.less
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/skins.minerva.beta.styles/pageactions.less
b/resources/skins.minerva.beta.styles/pageactions.less
index 2323bd3..9f6c79e 100644
--- a/resources/skins.minerva.beta.styles/pageactions.less
+++ b/resources/skins.minerva.beta.styles/pageactions.less
@@ -33,8 +33,16 @@
}
@media all and ( min-width: @deviceWidthTablet ) {
+ @totalIconSize: ( @iconSize + ( 2 * @iconGutterWidth ) );
+ @pageActionsWidth: 3 * @totalIconSize - @iconGutterWidth;
+
.heading-holder {
position: relative;
+ #section-0 {
+ // FIXME: No need for important when pushing language
switcher to stable 41
+ // Leave space for 3 icons
+ padding-right: @pageActionsWidth /
@firstHeadingFontSize * @pageActionFontSize !important;
+ }
}
#page-actions {
--
To view, visit https://gerrit.wikimedia.org/r/289701
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id97abc53c5e49d78d5cadadbf35a07670102f658
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jhernandez <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
